Autoconf: Explicit MOM_memory.h configuration#366
Merged
Hallberg-NOAA merged 1 commit intoNOAA-GFDL:dev/gfdlfrom May 29, 2023
Merged
Autoconf: Explicit MOM_memory.h configuration#366Hallberg-NOAA merged 1 commit intoNOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA merged 1 commit intoNOAA-GFDL:dev/gfdlfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #366 +/- ##
============================================
- Coverage 38.13% 38.13% -0.01%
============================================
Files 269 269
Lines 75743 75743
Branches 13926 13926
============================================
- Hits 28883 28882 -1
- Misses 41660 41662 +2
+ Partials 5200 5199 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MOM6 requires an explicit MOM_memory.h header to define its numerical
field memory layout. Previously, autoconf provided a flag to configure
this with `--enable-*`, but was prone to two issues:
* The binary choice of symmetric/nonsymmetric prevented use of static
headers.
* It was an incorrect use of `--enable-*`, which is intended to enable
additional internal features; it is not used to select a mode.
To address these issues, we drop the flag and replace it with an
AC_ARG_VAR variable, MOM_MEMORY, which is a path to the file. This
variable will default to dynamic symmetric mode,
config_src/memory/dynamic_symmetric/MOM_memory.h
so there should be no change for existing users.
To the best of my knowledge, no one used the `--enable-*` flag, nor was
it used in any automated systems (outside of .testing), so there should
be no issue with dropping it.
.testing/Makefile was updated to use MOM_MEMORY.
Hallberg-NOAA
force-pushed
the
ac_mom_mem_config
branch
from
d0b8c10 to
58ef026
Compare
Hallberg-NOAA
approved these changes
May 29, 2023
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes seem well-conceived and they have passed the pipeline testing at
https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/19310 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MOM6 requires an explicit MOM_memory.h header to define its numerical field memory layout. Previously, autoconf provided a flag to configure this with
--enable-*, but was prone to two issues:The binary choice of symmetric/nonsymmetric prevented use of static headers.
It was an incorrect use of
--enable-*, which is intended to enable additional internal features; it is not used to select a mode.To address these issues, we drop the flag and replace it with an AC_ARG_VAR variable, MOM_MEMORY, which is a path to the file. This variable will default to dynamic symmetric mode,
so there should be no change for existing users.
To the best of my knowledge, no one used the
--enable-*flag, nor was it used in any automated systems (outside of .testing), so there should be no issue with dropping it..testing/Makefile was updated to use MOM_MEMORY.