Autoconf: Fix Python test and allow configuration#371
Merged
marshallward merged 2 commits intoNOAA-GFDL:dev/gfdlfrom Jun 9, 2023
Merged
Autoconf: Fix Python test and allow configuration#371marshallward merged 2 commits intoNOAA-GFDL:dev/gfdlfrom
marshallward merged 2 commits intoNOAA-GFDL:dev/gfdlfrom
Conversation
The AC_PATH_PROGS macros used in Python testing were incorrectly using AC_MSG_ERROR in places where a missing value for PYTHON should be if the executable was not found. It also did not permit for a configurable PYTHON variable, since the autodetect was always run, even if PYTHON were set. This has been updated so that Python autodetection only runs if PYTHON is unset. It also correctly reports a failed configuration if PYTHON is not found. (It does not, however, test of PYTHON is actually a Python interpreter, but we can deal with that at a later date.)
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #371 +/- ##
============================================
- Coverage 38.38% 38.38% -0.01%
============================================
Files 268 268
Lines 76010 76010
Branches 13987 13987
============================================
- Hits 29176 29174 -2
- Misses 41595 41597 +2
Partials 5239 5239 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
raphaeldussin
approved these changes
Jun 5, 2023
Hallberg-NOAA
approved these changes
Jun 9, 2023
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I am formally approving this PR, in line with the review from Raf Dussin.
Member
Author
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/19455 ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AC_PATH_PROGS macros used in Python testing were incorrectly using AC_MSG_ERROR in places where a missing value for PYTHON should be if the executable was not found.
It also did not permit for a configurable PYTHON variable, since the autodetect was always run, even if PYTHON were set.
This has been updated so that Python autodetection only runs if PYTHON is unset. It also correctly reports a failed configuration if PYTHON is not found.
(It does not, however, test of PYTHON is actually a Python interpreter, but we can deal with that at a later date.)