+Add grid_unit_to_L to the ocean_grid_type#766
+Add grid_unit_to_L to the ocean_grid_type#766Hallberg-NOAA merged 1 commit intoNOAA-GFDL:dev/gfdlfrom
Conversation
MJHarrison-GFDL
left a comment
There was a problem hiding this comment.
The introduction of G%grid_unit_to_L makes sense and I approve. Unfortunate that this requires updating user code - unmerged user code on other forks will require manual updates.
4849612 to
8b7e7b9
Compare
Add the new element grid_unit_to_L to the ocean_grid_type and the dyn_horgrid_type, which can be used to convert the units of the geoLat and geoLon variables to rescaled horizontal distance units ([L ~> m]) when they are Cartesian coordinates. When Cartesian coordinates are not in use, G%grid_unit_to_L is set to 0. This new element of the grid type is used to test for inconsistent grids or to eliminate rescaling variables in set_rotation_beta_plane(), initialize_velocity_circular(), DOME_initialize_topography(), DOME_initialize_sponges(), DOME_set_OBC_data(), ISOMIP_initialize_topography(), idealized_hurricane_wind_forcing(), Kelvin_set_OBC_data(), Rossby_front_initialize_velocity(), soliton_initialize_thickness(), and soliton_initialize_velocity(). These are the instances where this new variable could be used and bitwise identical answers are recovered. There are a few other places where they should be used, but where answers would change, and these will be deferred to a subsequent commit. All answers are bitwise identical, but there are new elements in two transparent and widely used types.
8b7e7b9 to
8d98a4a
Compare
|
The use of this variable is not required, so if users do not want to update their code on other forks, they don't have to do anything. |
|
This was failing the pipeline testing on the first try for one case due to overly aggressive error detection on line 361 of |
Add the new element
grid_unit_to_Lto theocean_grid_typeand thedyn_horgrid_type, which can be used to convert the units of theG%geoLatandG%geoLonvariables to rescaled horizontal distance units ([L ~> m]) when they are Cartesian coordinates. When Cartesian coordinates are not in use,G%grid_unit_to_Lis set to 0.This new element of the grid type is used to test for inconsistent grids or to eliminate rescaling variables in
set_rotation_beta_plane(),initialize_velocity_circular(),DOME_initialize_topography(),DOME_initialize_sponges(),DOME_set_OBC_data(),ISOMIP_initialize_topography(),idealized_hurricane_wind_forcing(),Kelvin_set_OBC_data(),Rossby_front_initialize_velocity(),soliton_initialize_thickness(), andsoliton_initialize_velocity(). These are the instances where this new variable could be used and bitwise identical answers are recovered. There are a few other places where they should be used, but where answers would change, and these will be deferred to a subsequent commit.All answers are bitwise identical, but there are new elements in two transparent and widely used types.