Refactor horizontally_average_field#776
Merged
Hallberg-NOAA merged 1 commit intoNOAA-GFDL:dev/gfdlfrom Jan 7, 2025
Merged
Conversation
Hallberg-NOAA
added
the
refactor
MJHarrison-GFDL
approved these changes
Jan 7, 2025
MJHarrison-GFDL
left a comment
MJHarrison-GFDL
left a comment
There was a problem hiding this comment.
This commit makes complete sense. The code is cleaner in unscaled units.
marshallward
approved these changes
Jan 7, 2025
Refactored the horizontally_average_field() routine in MOM_diag_remap to work in rescaled units by making use of the unscale arguments to the reproducing_sum() routines. A total of 9 rescaling variables were moved into unscale arguments. All answers and diagnostics are bitwise identical, and no interfaces are changed.
Hallberg-NOAA
force-pushed
the
refactor_horizontally_average_field
branch
from
8c8e218 to
e15d37c
Compare
Member
Author
|
This PR passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/25968. |
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the
horizontally_average_field()routine inMOM_diag_remapto work in rescaled units by making use of theunscalearguments to thereproducing_sum()routines. A total of 9 rescaling variables were converted into a pair ofunscalearguments. All answers and diagnostics are bitwise identical, and no interfaces are changed.