Correct unit conversion for BS_coeff_h and BS_coeff_q diagnostics#779
Merged
Hallberg-NOAA merged 1 commit intoNOAA-GFDL:dev/gfdlfrom Jan 19, 2025
Merged
Conversation
adcroft
approved these changes
Jan 17, 2025
Member
Added missing conversion arguments for the register_diag_field calls for the recently added diagnostics BS_coeff_h and BS_coeff_q. All answers are bitwise identical, but two diagnostics will have corrected dimensional rescaling when EY24_EBT_BS is true.
Hallberg-NOAA
force-pushed
the
fix_BS_coef_h_diagostic
branch
from
1cd33ac to
5ee01c0
Compare
Member
Author
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26109. |
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the missing
conversionarguments to theregister_diag_field()calls for the recently added diagnosticsBS_coeff_handBS_coeff_q. All answers are bitwise identical, but two diagnostics will have corrected dimensional rescaling whenEY24_EBT_BS = True.