Bug fixes for sea surface height related diagnostics/checks#783
Merged
Hallberg-NOAA merged 3 commits intoNOAA-GFDL:dev/gfdlfrom Dec 30, 2024
Merged
Bug fixes for sea surface height related diagnostics/checks#783Hallberg-NOAA merged 3 commits intoNOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA merged 3 commits intoNOAA-GFDL:dev/gfdlfrom
Conversation
Correct a bug that G%gridLonT/G%gridLatT were not using global indexing in outputing extreme surface information.
Previously extreme surface message is triggered when `sea_lev` is smaller than or **equal** to ocean topography: sfc_state%sea_lev(i,j) <= -G%bathyT(i,j) - G%Z_ref The equality is innocuous for a non-zero minimum thickness (Angstrom/=0), but it can be problematic for true zero thickness. Besides, there is the fourth criterion in this check: sfc_state%sea_lev(i,j) + G%bathyT(i,j) + G%Z_ref < CS%bad_val_col_thick This is supposed to allow a user-specified tolerance (default=0.0), which should be a more stringent check when the tolerance is larger than zero. The equality from the first check contradicts this logic.
Fix a bug that sea surface height averaged over every dynamic time step (SSH_inst) is not outputted correctly.
Hallberg-NOAA
approved these changes
Dec 26, 2024
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes all seem correct to me.
Member
|
This PR has just passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/25876. |
Member
|
Because this PR fixes 3 distinct bugs, one in each of its 3 commits, I am going to retain them as separate commits and do a rebase rather than a squash merge. |
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains three minor fixes related to SSH diagnostics and checks, which address the following issues:
SSH_instAll answers are bitwise identical, but a diagnostics that has been unlikely used is recovered.