Fix dimensional rescaling in predict_MEKE#802
Merged
theresa-cordero merged 2 commits intoNOAA-GFDL:dev/gfdlfrom Jan 21, 2025
Merged
Fix dimensional rescaling in predict_MEKE#802theresa-cordero merged 2 commits intoNOAA-GFDL:dev/gfdlfrom
theresa-cordero merged 2 commits intoNOAA-GFDL:dev/gfdlfrom
Conversation
Refactored predict_MEKE() to include two missing dimensional rescaling factors and correct a third and to clearly indicate the units and the nature of the variables where they are being used, in coordination with Andrew Shao. Some white spacing around semicolons in the same MOM_MEKE file was also modified to follow the patterns used elsewhere in the MOM6 code. All answers are bitwise identical in cases that do not use dimensional rescaling.
|
@Hallberg-NOAA and I discussed this last week and I agree that the changes are correct given the implementation of the MEKE prediction |
marshallward
approved these changes
Jan 21, 2025
theresa-cordero
approved these changes
Jan 21, 2025
Member
Author
|
We have subsequently found that the changing code complexity in |
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored
predict_MEKE()to include two missing dimensional rescaling factors and correct a third and to clearly indicate the units and the nature of the variables where they are being used, in coordination with Andrew Shao. Some white spacing around semicolons in the same MOM_MEKE file was also modified to follow the patterns used elsewhere in the MOM6 code. All answers are bitwise identical in cases that do not use dimensional rescaling.