Refactor spherical_harmonics_forward#807
Merged
Hallberg-NOAA merged 1 commit intoNOAA-GFDL:dev/gfdlfrom Jan 23, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #807 +/- ##
=========================================
Coverage 38.16% 38.16%
=========================================
Files 296 296
Lines 87234 87228 -6
Branches 16283 16280 -3
=========================================
Hits 33291 33291
+ Misses 47956 47950 -6
Partials 5987 5987 ☔ View full report in Codecov by Sentry. |
herrwang0
approved these changes
Jan 19, 2025
herrwang0
left a comment
herrwang0
left a comment
There was a problem hiding this comment.
The changes make sense and look correct to me.
Hallberg-NOAA
added
the
refactor
marshallward
approved these changes
Jan 21, 2025
Refactored the spherical_harmonics_forward routine in MOM_spherical_harmonics to work in rescaled units by making use of the unscale arguments to reproducing_sum(). A total of 4 rescaling variables were moved into unscale arguments, and a block of code that restores the scaling of the output variables was eliminated. The comments describing the units of several variables in this module were made more explicit. The two temporary arrays that store un-summed contributions to the transforms were also moved out of the control structure and made into local variables in the spherical_harmonics_forward routine to allow for the reuse of that memory. All answers and diagnostics are bitwise identical, and no interfaces are changed.
Hallberg-NOAA
force-pushed
the
refactor_spherical_harmonics
branch
from
82780ac to
de3f5a4
Compare
Member
Author
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26163. |
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the
spherical_harmonics_forward()routine inMOM_spherical_harmonicsto work in rescaled units by making use of theunscalearguments toreproducing_sum(). A total of 4 rescaling variables were moved intounscalearguments, and a block of code that restores the scaling of the output variables was eliminated. The comments describing the units of several variables in this module were made more explicit. The two temporary arrays that store un-summed contributions to the transforms were also moved out of the control structure and made into local variables in thespherical_harmonics_forward()routine to allow for the reuse of that memory. All answers and diagnostics are bitwise identical, and no interfaces are changed.