Rescale volo and clean up the unit descriptions of 17 variables#820
Merged
Hallberg-NOAA merged 4 commits intoNOAA-GFDL:dev/gfdlfrom Feb 1, 2025
Merged
Conversation
Hallberg-NOAA
added
documentation
herrwang0
approved these changes
Jan 31, 2025
Calculate the volo diagnostic in scaled units using the tmp_scale argument to global_area_integral and undo this scaling with a conversion argument on its register_scalar_field call. Also corrected the units in the comments describing the mass_celland masso variables in calculate_diagnostic_fields. All answers are bitwise identical.
Renamed the internal variable tmpForSumming to masked_area in compute_global_grid_integrals and corrected the description of its units from [m2] to [L2 ~> m2]. All answers are bitwise identical.
Corrected incorrect syntax in the descriptions of 4 positions variables in write energy, 1 reused position variable in set_grid_metrics_from_mosaic and 1 position variable in bkgnd_mixing_CS. Also added the unscaled units to the comments documenting two lines of calculations in wave_speeds, and added the scaled units to two variables related to the ice-shelf surface mass balance. Only comments are changed and all answers are bitwise identical.
Replaced the unused real tide_flow element of the file_OBC_CS type with the logical OBC_file_used element to more clearly reflect that this placeholder element is only here to avoid having a completely empty type. The actual value of this element is irrelevant, but some compilers require that all Fortran types have at least one element. This change eliminates a meaningless hard-coded real variable with undefined units and a misleading name and replaces it with a logical variable named to reflect its actual purpose. All answers are bitwise identical.
Hallberg-NOAA
force-pushed
the
rescaled_volo_diagnostic
branch
from
1b142ba to
536869d
Compare
Member
Author
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26243. |
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consists of four commits that correct the descriptions of the units or purpose of some variables. Specifically this PR:
volodiagnosticmasked_areafor greater clarityfile_OBC_CSwith a logical placeholderAll solutions and output are bitwise identical, and no interfaces are changed. The specific commits in this PR include: