Skip to content

Debugging checksum on full range of Kh_h and Kh_q#822

Merged
Hallberg-NOAA merged 1 commit intoNOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA:full_range_Kh_h_checksum
Feb 19, 2025
Merged

Debugging checksum on full range of Kh_h and Kh_q#822
Hallberg-NOAA merged 1 commit intoNOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA:full_range_Kh_h_checksum

Conversation

@Hallberg-NOAA
Copy link
Member

Expand range of halos for checksums for Kh_h, Kh_q, Ah_h and Ah_q to cover the full range of values that are actually used. This includes expanding the range of values where the viscosities are calculated to those used in symmetric memory mode when DEBUG is true, even though these are not used for efficiency. One set of vorticity-point loop ranges was also corrected when the recently added parameter EY24_EBT_BS is true to avoid setting an extra unused value, perhaps correcting non-symmetric memory mode cases that would not reproduce across PE count and layout. All answers are bitwise identical in any case that reproduces across PE count.

@Hallberg-NOAA Hallberg-NOAA added bug Something isn't working enhancement New feature or request labels Feb 2, 2025
Copy link
Member

@marshallward marshallward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including halos in debug output seems very useful.

  Expand range of halos for checksums for Kh_h, Kh_q, Ah_h and Ah_q to cover the
full range of values that are actually used.  This includes expanding the range
of values where the viscosities are calculated to those used in symmetric memory
mode when DEBUG is true, even though these are not used for efficiency.  One set
of vorticity-point loop ranges was also corrected when the recently added
parameter EY24_EBT_BS is true to avoid setting an extra unused value, perhaps
correcting non-symmetric memory mode cases that would not reproduce across PE
count and layout.  All answers are bitwise identical in any case that
reproduces across PE count.
@Hallberg-NOAA Hallberg-NOAA force-pushed the full_range_Kh_h_checksum branch from 2af4d32 to 7ab2c3d Compare February 19, 2025 15:38
@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.70%. Comparing base (9924a19) to head (7ab2c3d).
Report is 1 commits behind head on dev/gfdl.

❗ There is a different number of reports uploaded between BASE (9924a19) and HEAD (7ab2c3d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9924a19) HEAD (7ab2c3d)
2 1
Additional details and impacted files
@@              Coverage Diff              @@
##           dev/gfdl     #822       +/-   ##
=============================================
- Coverage     38.10%   21.70%   -16.41%     
=============================================
  Files           298      137      -161     
  Lines         87644    33184    -54460     
  Branches      16418     5944    -10474     
=============================================
- Hits          33400     7203    -26197     
+ Misses        48226    25425    -22801     
+ Partials       6018      556     -5462     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hallberg-NOAA
Copy link
Member Author

This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26442.

@Hallberg-NOAA Hallberg-NOAA merged commit a71e0fb into NOAA-GFDL:dev/gfdl Feb 19, 2025
12 checks passed
kshedstrom pushed a commit to ESMG/MOM6 that referenced this pull request Mar 17, 2025
Expand range of halos for checksums for Kh_h, Kh_q, Ah_h and Ah_q to cover the
full range of values that are actually used.  This includes expanding the range
of values where the viscosities are calculated to those used in symmetric memory
mode when DEBUG is true, even though these are not used for efficiency.  One set
of vorticity-point loop ranges was also corrected when the recently added
parameter EY24_EBT_BS is true to avoid setting an extra unused value, perhaps
correcting non-symmetric memory mode cases that would not reproduce across PE
count and layout.  All answers are bitwise identical in any case that
reproduces across PE count.
@Hallberg-NOAA Hallberg-NOAA deleted the full_range_Kh_h_checksum branch April 22, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants