A few minor changes in vertical viscosity #838
Merged
Hallberg-NOAA merged 2 commits intoNOAA-GFDL:dev/gfdlfrom Feb 23, 2025
Merged
A few minor changes in vertical viscosity #838Hallberg-NOAA merged 2 commits intoNOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA merged 2 commits intoNOAA-GFDL:dev/gfdlfrom
Conversation
herrwang0
added
the
refactor
Hallberg-NOAA
approved these changes
Feb 22, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I agree that all of these changes are useful simplifications or clarifications of the code.
The field is never used by MOM_set_visc and incorrectly logged under MOM_set_visc section in MOM_parameter_doc, rather than MOM_kappa_shear.
* In subroutine set_viscous_BBL, move and merge `u2_bg` calculation to avoid redundancy and if-branch within do-loops. * In subroutine set_viscous_BBL, add a comment on explaining the reason to reset Ray_[uv] * In subroutine find_coupling_coef, replace an if-branch with min()
Hallberg-NOAA
force-pushed
the
fix_vertvisc_unused
branch
from
d63ea3b to
670ed29
Compare
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26485 with the expected warnings about a change in the order of entries in the MOM_parameter_doc files. |
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors a few random lines in vertical viscosity.
Prandtl_turbinvertvisc_type, which also allows the said parameter documented in the correct section in MOM_parameter_docset_viscous_BBL, move and merge two instances ofu2_bgcalculation to avoid redundancy and if-branch within do-loops.set_viscous_BBL, add a comment on explaining the reason to reset Ray_[uv]find_coupling_coef, replace an if-branch with min()This PR does not change answers.
05b1e06: Remove Prandtl_turb from vertvisc_type
d63ea3b: Minor changes to vertical viscosity