Add RESET_INTXPA_INTEGRAL_FLATTEST option to pressure gradient#843
Merged
Hallberg-NOAA merged 2 commits intoNOAA-GFDL:dev/gfdlfrom Mar 3, 2025
Merged
Conversation
Hallberg-NOAA
requested changes
Mar 3, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I really appreciate this contribution, and I am tempted to accept it as is, but I would prefer that the comment describing the new runtime parameter RESET_INTEXPA_INTEGRAL_FLATTEST refer to flat interfaces rather than flat layers.
Hallberg-NOAA
approved these changes
Mar 3, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
Thank you very much for this valuable new contribution!
This new parameter RESET_INTXPA_INTEGRAL_FLATTEST modifies the reference interface for the horizontal pressure integrals in the finite volume pressure gradient force calculation. If true, in ocean columns where no non-tilted, non-vanished layer can be found (e.g. near specific shaped ice shelf grounding lines), rather than using the top surface to integrate downwards as the reference, the code finds and chooses the flattest (i.e. minimum difference between depth or pressure) interface as the reference. The parameter defaults to False therefore should not change default answers. However, if true, combined with other ice shelf code changes e.g. MASS_WEIGHT_IN_PGF_VANISHED_ONLY = True, RESET_INTXPA_INTEGRAL = True, MASS_WEIGHT_IN_PRESSURE_GRADIENT = True and MASS_WEIGHT_IN_PRESSURE_GRADIENT_TOP = True + initialisation code fixes I get very low spurious currents in the Boussinesq ZSTAR and SIGMA_SHELF_ZSTAR ISOMIP+ test cases.
to refer to flattest interface rather than flattest layer.
Hallberg-NOAA
force-pushed
the
dev/gfdl-jan26_2025+flattest_ref_layer
branch
from
bb7a11e to
b7d7e8a
Compare
Hallberg-NOAA
added
enhancement
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26599 with the expected warnings about new runtime parameters. |
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new parameter
RESET_INTXPA_INTEGRAL_FLATTESTmodifies the reference interface for the horizontal pressure integrals in the finite volume pressure gradient force calculation. If true, in ocean columns where no non-tilted, non-vanished layer can be found (e.g. near specific shaped ice shelf grounding lines), rather than using the top surface to integrate downwards as the reference, the code finds and chooses the flattest (i.e. minimum difference between depth or pressure) interface as the reference.The parameter defaults to False therefore should not change default answers. However, if true, combined with other ice shelf code changes e.g.
MASS_WEIGHT_IN_PGF_VANISHED_ONLY= True,RESET_INTXPA_INTEGRAL= True,MASS_WEIGHT_IN_PRESSURE_GRADIENT= True andMASS_WEIGHT_IN_PRESSURE_GRADIENT_TOP= True + initialisation code fixes I get very low spurious currents in the Boussinesq ZSTAR and SIGMA_SHELF_ZSTAR ISOMIP+ test cases (note non-Boussinesq still not quiet).This is an alternative to the inconsistent and slow, closed PR #811