Add INTERFACE_FILTER_DT_BUG#850
Merged
Hallberg-NOAA merged 2 commits intoNOAA-GFDL:dev/gfdlfrom Mar 10, 2025
Merged
Conversation
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
Having read through these proposed changes, I am convinced that they are correct, but I think that before merging this in I would like to see whether @theresa-cordero agrees.
|
I agree, this bug fix makes sense. |
Hallberg-NOAA
approved these changes
Mar 10, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
We have a consensus for approval!
In non-Boussinesq mode, calc_derived_thermo needs to be called before diag_update_remap_grids. Commit 23b2049 appears to require an extra call. Without the call, MOM6 issues a FATAL error message.
A new parameter, INTERFACE_FILTER_DT_BUG, is added to fix two bugs in the time interval passed to interface_filter and to thickness_diffuse. This parameter has no effect, and is not read or logged, when THICKNESSDIFFUSE_FIRST is true and DT_TRACER_ADVECT = DT_THERMO or when both THICKNESSDIFFUSE_FIRST and APPLY_INTERFACE_FILTER are false. Its default is false which will change answers in the rare existing cases with the bug. In such cases, the original answers can be restored by setting INTERFACE_FILTER_DT_BUG to true.
Hallberg-NOAA
force-pushed
the
INTERFACE_FILTER_DT_BUG
branch
from
6084824 to
ccb7f3c
Compare
Hallberg-NOAA
added
bug
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26699 with the expected warnings about a new runtime parameter and the reordering of some existing parameters in the MOM_parameter_doc files. |
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new parameter, INTERFACE_FILTER_DT_BUG, is added to fix two bugs in
the time interval passed to interface_filter and to thickness_diffuse.
This parameter has no effect, and is not read or logged, when
THICKNESSDIFFUSE_FIRST is true and DT_TRACER_ADVECT = DT_THERMO or
when both THICKNESSDIFFUSE_FIRST and APPLY_INTERFACE_FILTER are false.
Its default is false which will change answers in the rare existing cases
with the bug. In such cases, the original answers can be restored by
setting INTERFACE_FILTER_DT_BUG to true.
In addition, a missing calc_derived_thermo call has been added:
In non-Boussinesq mode, calc_derived_thermo needs to be called before
diag_update_remap_grids. Commit 23b2049 appears to require an extra call.
Without the call, MOM6 issues a FATAL error message.