Horvisc: Reorder if-blocks in rescaled Kh#862
Merged
Hallberg-NOAA merged 1 commit intoNOAA-GFDL:dev/gfdlfrom Mar 20, 2025
Merged
Horvisc: Reorder if-blocks in rescaled Kh#862Hallberg-NOAA merged 1 commit intoNOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA merged 1 commit intoNOAA-GFDL:dev/gfdlfrom
Conversation
Hallberg-NOAA
approved these changes
Mar 19, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes all look functionally equivalent to me, and I trust @marshallward when he says that this revised construct with the logic outside of the do-loops should perform better.
Hallberg-NOAA
added
the
refactor
This reorders several if-blocks inside of a large do-loop of horizontal_viscosity() associated with rescaled Kh. This should help performance, but will also make it easier to move these loops to GPU.
Hallberg-NOAA
force-pushed
the
reorder_horvisc_kh_loop
branch
from
78966a8 to
c6bd685
Compare
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26796. |
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reorders several if-blocks inside of a large do-loop of horizontal_viscosity() associated with rescaled Kh.
This should help performance, but will also make it easier to move these loops to GPU.