Skip to content

[Update] Upgrade to the numpy 2x series#415

Merged
FlorianDeconinck merged 25 commits intoNOAA-GFDL:developfrom
twicki:update/test_numpy_24
Apr 1, 2026
Merged

[Update] Upgrade to the numpy 2x series#415
FlorianDeconinck merged 25 commits intoNOAA-GFDL:developfrom
twicki:update/test_numpy_24

Conversation

@twicki
Copy link
Copy Markdown
Collaborator

@twicki twicki commented Apr 1, 2026

(Superseeding #389)

Description

Catching up to our upstream dependency and pushing NDSL to support numpy 2.x.

In order to not be brought back into the past, I propose we force the usage of 2.x

Downstream:

  • NumpyModules in ndsl.types was a shadow class used for type hinting between cupy and numpy. With the numpy API evolving, the shadow class would explode in complexity

PRs in other repos

How has this been tested?

Running unit test

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@FlorianDeconinck FlorianDeconinck changed the title test [WIP] Numpy 2x Apr 1, 2026
@FlorianDeconinck FlorianDeconinck changed the title [WIP] Numpy 2x [WIP] Upgrade to the numpy 2x series Apr 1, 2026
@FlorianDeconinck FlorianDeconinck self-requested a review April 1, 2026 20:17
Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI from https://github.com/NOAA-GFDL/NDSL/pull/415/commits/827369f0965a54d1a820076be82299e8d370ddcb was ✔️

Now reverting the ciworkflow to develop and pushing in

@FlorianDeconinck FlorianDeconinck marked this pull request as ready for review April 1, 2026 20:31
@FlorianDeconinck FlorianDeconinck changed the title [WIP] Upgrade to the numpy 2x series [Update] Upgrade to the numpy 2x series Apr 1, 2026
@FlorianDeconinck FlorianDeconinck mentioned this pull request Apr 1, 2026
7 tasks
@FlorianDeconinck FlorianDeconinck added this pull request to the merge queue Apr 1, 2026
@FlorianDeconinck FlorianDeconinck removed this pull request from the merge queue due to a manual request Apr 1, 2026
@FlorianDeconinck FlorianDeconinck added this pull request to the merge queue Apr 1, 2026
Merged via the queue into NOAA-GFDL:develop with commit 4294976 Apr 1, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants