Remove OUTSIDE_DOCKER papiex path, show build output at install time#173
Merged
ilaflott merged 9 commits intocopilot/integrate-papiex-compile-stepfrom Mar 27, 2026
Conversation
…mpile_papiex.sh Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…ubprocess stdout stderr piping which obscures good output in the github CI
Makefile: - Remove OUTSIDE_DOCKER branch from papiex-dist rule (docker-dist only) - Update python-dist comments to document Docker-only usage - Clean up extracted papiex-epmt-install/ dir after copying .so files build_and_test_epmt.yml: - Remove OUTSIDE_DOCKER papiex tarball cache/build steps - Replace sdist-based install with direct pip install ./src - Remove -v -v flags (output now visible by default) weekly_cache_builds.yml: - Remove OUTSIDE_DOCKER papiex build/verify/cache steps setup.py: - Tee compile_papiex.sh output to /dev/tty (bypasses pip capture) - Fall back to stderr when no TTY available (CI) - Always write to install_papiex.log .gitignore: - Add src/build/, src/epmt/bin/, src/epmt/include/ Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## copilot/integrate-papiex-compile-step #173 +/- ##
======================================================================
Coverage 76.34% 76.34%
======================================================================
Files 34 34
Lines 6676 6676
======================================================================
Hits 5097 5097
Misses 1579 1579
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
this will not be ready for releasing 5.0.0, that is OK. |
ilaflott
force-pushed
the
copilot/integrate-papiex-compile-step
branch
from
928557f to
52ac9f7
Compare
…ove-outside-docker-papiex-v2
ilaflott
merged commit 713b675
into
copilot/integrate-papiex-compile-step
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #171. Removes the bare-metal OUTSIDE_DOCKER papiex compilation path (now handled by compile_papiex.sh at pip install time) and makes papiex build output visible to the user without needing
-vflags.Changes
setup.py — Tee compile_papiex.sh output to
/dev/tty(bypasses pip's stdout/stderr capture). Falls back to stderr when no TTY is available (CI). Always writes toinstall_papiex.log.Makefile — Remove
OUTSIDE_DOCKERbranch frompapiex-distrule (docker-dist only). Clean up extractedpapiex-epmt-install/dir after copying .so files.build_and_test_epmt.yml — Remove OUTSIDE_DOCKER papiex tarball cache/build steps. Replace sdist-based install with direct
pip install ./src. Remove-v -vflags (output now visible by default).weekly_cache_builds.yml — Remove OUTSIDE_DOCKER papiex build/verify/cache steps.
.gitignore — Add
src/build/,src/epmt/bin/,src/epmt/include/(papiex compilation byproducts).Verified locally