Skip to content

Conversation

@bpulluta
Copy link
Collaborator

@bpulluta bpulluta commented Jan 15, 2026

This PR implements geothermal electricity ordinance extraction for COMPASS, addressing issue #245.

Progress on Issue #245 Steps

Changes

New Module: compass/extraction/geothermal_electricity/

  • ordinance.py: Feature definitions and ordinance structure for geothermal power plants
  • graphs.py: Graph extraction logic for regulatory relationships and requirements
  • parse.py: LLM-based parsing implementation for extracting ordinance features

Features Extracted

  • Setbacks (structures, property lines, roads, water bodies, wells, faults, etc.)
  • Drilling hours requirements
  • Noise limits
  • Height restrictions
  • Lot size requirements

Next Steps

  • Integration with main COMPASS processing pipeline
  • Validation module implementation
  • Additional testing with broader jurisdiction set
  • Team review and feedback

Notes

This is an initial implementation ready for team collaboration and further development.

Copilot AI review requested due to automatic review settings January 15, 2026 18:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 320 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.35%. Comparing base (42b57b7) to head (cb06ddb).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
compass/extraction/geothermal_electricity/parse.py 0.00% 162 Missing ⚠️
...ass/extraction/geothermal_electricity/ordinance.py 0.00% 113 Missing ⚠️
...ompass/extraction/geothermal_electricity/graphs.py 0.00% 45 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   55.49%   52.35%   -3.15%     
==========================================
  Files          45       48       +3     
  Lines        4303     4636     +333     
  Branches      391      412      +21     
==========================================
+ Hits         2388     2427      +39     
- Misses       1888     2180     +292     
- Partials       27       29       +2     
Flag Coverage Δ
unittests 52.35% <0.00%> (-3.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Delete unfinished graphs.py and parse.py (still had solar code)
- Update __init__.py to only export implemented ordinance classes
- Add 27 geothermal electricity heuristic tests to existing test_extraction_validation.py
- All tests pass, following same pattern as wind/solar tests
@bpulluta bpulluta marked this pull request as draft January 15, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants