add the mcore interface for optim arg; average_in_collective#10010
Merged
erhoo82 merged 1 commit intoNVIDIA-NeMo:mainfrom Aug 7, 2024
Merged
add the mcore interface for optim arg; average_in_collective#10010erhoo82 merged 1 commit intoNVIDIA-NeMo:mainfrom
erhoo82 merged 1 commit intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: Sangkug Lym <slym@nvidia.com>
erhoo82
force-pushed
the
mcore_interface
branch
from
cca043d to
6e3e0cd
Compare
adityavavre
pushed a commit
to adityavavre/NeMo
that referenced
this pull request
Sep 15, 2024
…NeMo#10010) Signed-off-by: Sangkug Lym <slym@nvidia.com> Signed-off-by: adityavavre <aditya.vavre@gmail.com>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
Signed-off-by: Sangkug Lym <slym@nvidia.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
…NeMo#10010) Signed-off-by: Sangkug Lym <slym@nvidia.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
…NeMo#10010) Signed-off-by: Sangkug Lym <slym@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add the interface to pass the argument for gradient average reduction to MegatronCore
Changelog
average_in_collectiveUsage
model.optim.average_in_collectiveto enableGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information