-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add cross-attention to output hypotheses #15229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nithinraok
merged 12 commits into
NVIDIA-NeMo:main
from
mgaido91:add_attention_to_output_hypo
Jan 23, 2026
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
21d5bb8
Add cross-attention to output hypotheses
mgaido91 bdca576
Merge branch 'main' of github.com:NVIDIA-NeMo/NeMo into add_attention…
mgaido91 4f632bd
update comment based on review
mgaido91 8c8005f
Apply isort and black reformatting
mgaido91 3470328
add parameter to con trol whether to return xattn
mgaido91 e06e0c4
Apply isort and black reformatting
mgaido91 0b5b12f
avoid useless import
mgaido91 b72e67f
Merge branch 'main' of github.com:NVIDIA-NeMo/NeMo into add_attention…
mgaido91 9e5e77a
Merge branch 'main' of github.com:NVIDIA-NeMo/NeMo into add_attention…
mgaido91 3a79319
Merge branch 'main' of github.com:NVIDIA-NeMo/NeMo into add_attention…
mgaido91 6983fcc
update tests base on comment
mgaido91 523bd22
Merge branch 'main' into add_attention_to_output_hypo
nithinraok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.