Modelopt Refactor for SDXL Quantization#9279
Merged
Conversation
Edwardf0t1
reviewed
May 28, 2024
Collaborator
Edwardf0t1
left a comment
Edwardf0t1
left a comment
There was a problem hiding this comment.
Thanks for taking care of the modelopt updates in NeMo. I think if you use VS Code it's easy to do a global search in the repo to catch all the instances such as ammo , ato, atq.
suiyoubi
force-pushed
the
aot/modelopt-refactor
branch
from
60c582f to
5c23a3d
Compare
Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>
Edwardf0t1
previously approved these changes
Jun 6, 2024
Collaborator
Edwardf0t1
left a comment
Edwardf0t1
left a comment
There was a problem hiding this comment.
@suiyoubi Left a few comments. LGTM in general.
|
|
||
| try: | ||
| import ammo.torch.quantization as atq | ||
| import modelopt.torch.quantization as atq |
|
|
||
| import ammo.torch.opt as ato | ||
| import ammo.torch.quantization as atq | ||
| import modelopt.torch.opt as ato |
| import ammo.torch.opt as ato | ||
| import ammo.torch.quantization as atq | ||
| import modelopt.torch.opt as ato | ||
| import modelopt.torch.quantization as atq |
JesusPaz
pushed a commit
to JesusPaz/NeMo
that referenced
this pull request
Jun 18, 2024
* modelopt refactor * refactor all ammo occurrences to modelopt * Apply isort and black reformatting Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com> * rename atq->mtq ato->mto --------- Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com> Co-authored-by: suiyoubi <suiyoubi@users.noreply.github.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* modelopt refactor * refactor all ammo occurrences to modelopt * Apply isort and black reformatting Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com> * rename atq->mtq ato->mto --------- Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com> Co-authored-by: suiyoubi <suiyoubi@users.noreply.github.com>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
* modelopt refactor * refactor all ammo occurrences to modelopt * Apply isort and black reformatting Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com> * rename atq->mtq ato->mto --------- Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com> Co-authored-by: suiyoubi <suiyoubi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information