Skip to content

Comments

Update build_dataset.py#9467

Merged
titu1994 merged 5 commits intomainfrom
stevehuang52-patch-1
Jun 13, 2024
Merged

Update build_dataset.py#9467
titu1994 merged 5 commits intomainfrom
stevehuang52-patch-1

Conversation

@stevehuang52
Copy link
Collaborator

fix bug during eval

fix bug during eval

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
stevehuang52 and others added 4 commits June 13, 2024 15:20
Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
Signed-off-by: stevehuang52 <stevehuang52@users.noreply.github.com>
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@titu1994 titu1994 merged commit f47209b into main Jun 13, 2024
@titu1994 titu1994 deleted the stevehuang52-patch-1 branch June 13, 2024 19:25
JesusPaz pushed a commit to JesusPaz/NeMo that referenced this pull request Jun 18, 2024
* Update build_dataset.py

fix bug during eval

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>

* Update build_dataset.py

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>

* Update build_dataset.py

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>

* Update build_dataset.py

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>

* Apply isort and black reformatting

Signed-off-by: stevehuang52 <stevehuang52@users.noreply.github.com>

---------

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
Signed-off-by: stevehuang52 <stevehuang52@users.noreply.github.com>
Co-authored-by: stevehuang52 <stevehuang52@users.noreply.github.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* Update build_dataset.py

fix bug during eval

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>

* Update build_dataset.py

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>

* Update build_dataset.py

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>

* Update build_dataset.py

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>

* Apply isort and black reformatting

Signed-off-by: stevehuang52 <stevehuang52@users.noreply.github.com>

---------

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
Signed-off-by: stevehuang52 <stevehuang52@users.noreply.github.com>
Co-authored-by: stevehuang52 <stevehuang52@users.noreply.github.com>
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
2 tasks
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
* Update build_dataset.py

fix bug during eval

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>

* Update build_dataset.py

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>

* Update build_dataset.py

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>

* Update build_dataset.py

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>

* Apply isort and black reformatting

Signed-off-by: stevehuang52 <stevehuang52@users.noreply.github.com>

---------

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
Signed-off-by: stevehuang52 <stevehuang52@users.noreply.github.com>
Co-authored-by: stevehuang52 <stevehuang52@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants