Skip to content

Comments

In framework deploy using deploy script#9468

Merged
oyilmaz-nvidia merged 15 commits intoNVIDIA-NeMo:mainfrom
oyilmaz-nvidia:onur/in_framework_deploy
Jun 17, 2024
Merged

In framework deploy using deploy script#9468
oyilmaz-nvidia merged 15 commits intoNVIDIA-NeMo:mainfrom
oyilmaz-nvidia:onur/in_framework_deploy

Conversation

@oyilmaz-nvidia
Copy link
Collaborator

What does this PR do ?

In framework deploy using deploy script

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
@oyilmaz-nvidia oyilmaz-nvidia marked this pull request as ready for review June 14, 2024 19:18
oyilmaz-nvidia and others added 3 commits June 14, 2024 15:18
Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
oyilmaz-nvidia and others added 3 commits June 14, 2024 15:28
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>
meatybobby
meatybobby previously approved these changes Jun 14, 2024
Copy link
Collaborator

@meatybobby meatybobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oyilmaz-nvidia oyilmaz-nvidia merged commit d13e532 into NVIDIA-NeMo:main Jun 17, 2024
JesusPaz pushed a commit to JesusPaz/NeMo that referenced this pull request Jun 18, 2024
* fix minor import bug

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* deploy in-framework model with script

* make query_llm work with in framework models

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* added in framework test

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>

* Apply isort and black reformatting

Signed-off-by: artbataev <artbataev@users.noreply.github.com>

* fix codeql issues

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>

* rename test filename to avoid nemo ci issues

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

---------

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Co-authored-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>
Co-authored-by: artbataev <artbataev@users.noreply.github.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* fix minor import bug

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* deploy in-framework model with script

* make query_llm work with in framework models

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* added in framework test

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>

* Apply isort and black reformatting

Signed-off-by: artbataev <artbataev@users.noreply.github.com>

* fix codeql issues

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>

* rename test filename to avoid nemo ci issues

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

---------

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Co-authored-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>
Co-authored-by: artbataev <artbataev@users.noreply.github.com>
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
2 tasks
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
* fix minor import bug

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* deploy in-framework model with script

* make query_llm work with in framework models

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* added in framework test

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>

* Apply isort and black reformatting

Signed-off-by: artbataev <artbataev@users.noreply.github.com>

* fix codeql issues

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>

* rename test filename to avoid nemo ci issues

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

---------

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Co-authored-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>
Co-authored-by: artbataev <artbataev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants