Skip to content

Comments

[NeMo-UX] Fixing imports of NeMoLogging, AutoResume & ModelCheckpoint#9476

Merged
marcromeyn merged 5 commits intomainfrom
nemo-ux/exp-manager-imports
Jun 17, 2024
Merged

[NeMo-UX] Fixing imports of NeMoLogging, AutoResume & ModelCheckpoint#9476
marcromeyn merged 5 commits intomainfrom
nemo-ux/exp-manager-imports

Conversation

@marcromeyn
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@marcromeyn marcromeyn marked this pull request as ready for review June 14, 2024 21:48
@marcromeyn marcromeyn requested a review from ashors1 June 14, 2024 21:49
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
@marcromeyn marcromeyn merged commit 8a0d1f7 into main Jun 17, 2024
@marcromeyn marcromeyn deleted the nemo-ux/exp-manager-imports branch June 17, 2024 10:10
JesusPaz pushed a commit to JesusPaz/NeMo that referenced this pull request Jun 18, 2024
…NVIDIA-NeMo#9476)

* Fixing imports of NeMoLogging, AutoResume & ModelCheckpoint

* Apply isort and black reformatting

Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>

---------

Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
…NVIDIA-NeMo#9476)

* Fixing imports of NeMoLogging, AutoResume & ModelCheckpoint

* Apply isort and black reformatting

Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>

---------

Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
2 tasks
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
…NVIDIA-NeMo#9476)

* Fixing imports of NeMoLogging, AutoResume & ModelCheckpoint

* Apply isort and black reformatting

Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>

---------

Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants