fix: ensure that we check for pad_token and not assume pad_token==eos…#120
Merged
parthchadha merged 2 commits intomainfrom Apr 2, 2025
Merged
fix: ensure that we check for pad_token and not assume pad_token==eos…#120parthchadha merged 2 commits intomainfrom
parthchadha merged 2 commits intomainfrom
Conversation
…_token Signed-off-by: Parth Chadha <pchadha@nvidia.com>
Contributor
Author
|
#121 will add functional tests. Unit tests won't catch this failure since we need to invoke the grpo or sft algorithm for an iteration to catch this issue. |
terrykong
requested changes
Apr 2, 2025
ashors1
reviewed
Apr 2, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
728e534 to
2983ca7
Compare
terrykong
approved these changes
Apr 2, 2025
KiddoZhu
pushed a commit
that referenced
this pull request
May 6, 2025
#120) Signed-off-by: Parth Chadha <pchadha@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…_token
What does this PR do ?
There were wrong assumptions in grpo and sft that pad_token will be the same as eos_token.
Issues
Closes #119.
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information