Merged
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
b08e3d9 to
e685ec8
Compare
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Contributor
Author
|
@terrykong I updated based on your feedback. Please take another look. After merging, I assume we'll want to change the required check to the CI quality check step instead. |
terrykong
previously approved these changes
Apr 2, 2025
Collaborator
terrykong
left a comment
There was a problem hiding this comment.
approved modulo that FIXME comment
Collaborator
|
also a reminder that we need to change the status check to that QA one after this goes in |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
terrykong
approved these changes
Apr 2, 2025
Collaborator
|
for posterity of those stumbling on this PR, this change helps our CI run a little faster since spin-up and spin-down of containers is slow on CI infra (like 3 min per test that needs docker images) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Runs tests in the same job to minimize the overall workflow time
FROM basestep. But due to that, the docker image won't have any of the dependencies and so the tests will reinstall them--no-syncso that they do not attempt to reinstall dependenciesSomething on main seems to have broken the unit tests. So I defined the test script to always exist 0 to see what all the errors were. We'll want to fix those on this branch or at least before we merge this PR.
The functional tests seem to be taking too long. I set the overall tests timeout for this job to 15 minutes, and it could not complete with the functional tests. Was that expected at this stage? Perhaps we can just completely comment them out.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information