fix: Do not initialize reference model for sft#71
Merged
Conversation
Signed-off-by: ashors1 <ashors@nvidia.com>
ashors1
changed the title
parthchadha
previously approved these changes
Mar 24, 2025
terrykong
previously approved these changes
Mar 26, 2025
Contributor
SahilJain314
left a comment
SahilJain314
left a comment
There was a problem hiding this comment.
Can you modify SFT tests to use init_reference_model=False?
Contributor
Author
Do you mean adding a new test? The SFT functional test will of course already use |
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
terrykong
reviewed
Apr 1, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
ashors1
force-pushed
the
ashors/sft-remove-ref-model
branch
from
522633f to
122f37a
Compare
SahilJain314
approved these changes
Apr 1, 2025
Contributor
SahilJain314
left a comment
SahilJain314
left a comment
There was a problem hiding this comment.
Tests look good, thanks
parthchadha
approved these changes
Apr 1, 2025
terrykong
approved these changes
Apr 1, 2025
yfw
pushed a commit
that referenced
this pull request
Apr 2, 2025
Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com>
KiddoZhu
pushed a commit
that referenced
this pull request
May 6, 2025
Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information