fix: Enforce minimum packed sequence bin count and multiple of bin count#748
Merged
SahilJain314 merged 2 commits intomainfrom Jul 25, 2025
Merged
fix: Enforce minimum packed sequence bin count and multiple of bin count#748SahilJain314 merged 2 commits intomainfrom
SahilJain314 merged 2 commits intomainfrom
Conversation
Signed-off-by: Sahil Jain <sahilj@nvidia.com>
Contributor
|
Thank you @SahilJain314 test and verified your fix on my end as well. |
terrykong
reviewed
Jul 25, 2025
terrykong
reviewed
Jul 25, 2025
jiemingz
approved these changes
Jul 25, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
chtruong814
pushed a commit
that referenced
this pull request
Jul 25, 2025
…unt (#748) Signed-off-by: Sahil Jain <sahilj@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jul 28, 2025
…unt (NVIDIA-NeMo#748) Signed-off-by: Sahil Jain <sahilj@nvidia.com>
rohitrango
pushed a commit
that referenced
this pull request
Jul 29, 2025
…unt (#748) Signed-off-by: Sahil Jain <sahilj@nvidia.com>
wedu-nvidia
pushed a commit
to wedu-nvidia/RL
that referenced
this pull request
Jul 30, 2025
…unt (NVIDIA-NeMo#748) Signed-off-by: Sahil Jain <sahilj@nvidia.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jul 30, 2025
…unt (NVIDIA-NeMo#748) Signed-off-by: Sahil Jain <sahilj@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
…unt (NVIDIA-NeMo#748) Signed-off-by: Sahil Jain <sahilj@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
…unt (NVIDIA-NeMo#748) Signed-off-by: Sahil Jain <sahilj@nvidia.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Aug 13, 2025
…unt (NVIDIA-NeMo#748) Signed-off-by: Sahil Jain <sahilj@nvidia.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
jiemingz
pushed a commit
that referenced
this pull request
Aug 20, 2025
…unt (#748) Signed-off-by: Sahil Jain <sahilj@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes bin counts being too low with GBS is low as reported by @ZhiyuLi-Nvidia and also #718.