fix: Change optional-dependencies to dependency-groups#81
Conversation
|
For context, this fixes my reversion of adding them into optional dependencies. If using |
terrykong
left a comment
There was a problem hiding this comment.
actually there are a few other places we used --extra, can you grep for them and update?
I updated them all. Can you link any I missed? I can't seem to find them in the repo search. |
|
|
426df31 to
b7b67f1
Compare
I guess I didn't rebase. Rebased and updated in b7b67f1 |
|
@hemildesai another merge conflict 😅 |
Signed-off-by: Hemil Desai <hemild@nvidia.com>
b7b67f1 to
d88daa7
Compare
Rebased to latest main |
Signed-off-by: Hemil Desai <hemild@nvidia.com> Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
What does this PR do ?
Changes
project.optional-dependenciestodependency-groupsin pyproject.toml.Usage
uv run --group test pytest tests/Before your PR is "Ready for review"
Pre checks:
Additional Information