Skip to content

fix: Change optional-dependencies to dependency-groups#81

Merged
terrykong merged 2 commits intomainfrom
hemil/dep-groups
Apr 1, 2025
Merged

fix: Change optional-dependencies to dependency-groups#81
terrykong merged 2 commits intomainfrom
hemil/dep-groups

Conversation

@hemildesai
Copy link
Copy Markdown
Contributor

@hemildesai hemildesai commented Mar 25, 2025

What does this PR do ?

Changes project.optional-dependencies to dependency-groups in pyproject.toml.

Usage

  • You can potentially add a usage example below
uv run --group test pytest tests/

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@hemildesai hemildesai requested a review from terrykong March 25, 2025 18:38
@github-actions github-actions Bot added Documentation Improvements or additions to documentation CI Relating to CI labels Mar 25, 2025
@terrykong
Copy link
Copy Markdown
Collaborator

For context, this fixes my reversion of adding them into optional dependencies.

If using uv pip compile from uv==0.6.6, groups were not yet supported, but this is not an issue at least observed in uv==0.6.8

Copy link
Copy Markdown
Collaborator

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually there are a few other places we used --extra, can you grep for them and update?

@hemildesai
Copy link
Copy Markdown
Contributor Author

hemildesai commented Mar 25, 2025

actually there are a few other places we used --extra, can you grep for them and update?

I updated them all. Can you link any I missed? I can't seem to find them in the repo search.

@terrykong
Copy link
Copy Markdown
Collaborator

docker/Dockerfile:RUN uv sync --extra test --extra dev --extra docs --no-install-project

@hemildesai
Copy link
Copy Markdown
Contributor Author

docker/Dockerfile:RUN uv sync --extra test --extra dev --extra docs --no-install-project

I guess I didn't rebase. Rebased and updated in b7b67f1

@terrykong
Copy link
Copy Markdown
Collaborator

@hemildesai another merge conflict 😅

Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
@hemildesai
Copy link
Copy Markdown
Contributor Author

@hemildesai another merge conflict 😅

Rebased to latest main

@terrykong terrykong merged commit 69e967f into main Apr 1, 2025
11 checks passed
@terrykong terrykong deleted the hemil/dep-groups branch April 1, 2025 18:21
yfw pushed a commit that referenced this pull request Apr 2, 2025
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
KiddoZhu pushed a commit that referenced this pull request May 6, 2025
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Relating to CI Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants