Skip to content

style(test): apply shfmt formatting to E2E scripts#2359

Open
ericksoa wants to merge 1 commit intomainfrom
fix/e2e-shfmt-formatting
Open

style(test): apply shfmt formatting to E2E scripts#2359
ericksoa wants to merge 1 commit intomainfrom
fix/e2e-shfmt-formatting

Conversation

@ericksoa
Copy link
Copy Markdown
Contributor

@ericksoa ericksoa commented Apr 23, 2026

Summary

The squash merge of #2351 skipped pre-commit hooks, leaving shfmt formatting violations that broke the main workflow checks. This applies shfmt -w to fix them.

Test plan

  • shfmt -d produces no diff on both files

Summary by CodeRabbit

Release Notes

  • Tests
    • Improved formatting and readability of test scripts with no functional changes to test behavior or coverage.

Note: These are internal testing improvements with no visible impact on end-user functionality.

The squash merge of #2351 skipped pre-commit hooks, leaving shfmt
formatting violations in the snapshot-commands and deployment-services
test scripts. Run shfmt -w to fix.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4ab43689-75c0-49fa-853b-f2386dc75c36

📥 Commits

Reviewing files that changed from the base of the PR and between b90b4d3 and 757dcb5.

📒 Files selected for processing (2)
  • test/e2e/test-deployment-services.sh
  • test/e2e/test-snapshot-commands.sh

📝 Walkthrough

Walkthrough

Two shell test scripts are reformatted to adjust indentation within conditional blocks and restructure multi-line command chains. The cloudflared installation condition and snapshot verification logic are rewritten to use explicit && chaining instead of backslash-continued formatting, preserving existing control flow.

Changes

Cohort / File(s) Summary
Shell Script Formatting
test/e2e/test-deployment-services.sh, test/e2e/test-snapshot-commands.sh
Indentation adjustments within case statements and conditional blocks; rewritten multi-line command chains to use explicit && chaining instead of backslash line-continuation formatting. No behavioral or control flow changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Indents were dancing, askew on the stage,
So we lined them up neat on each whitespace page,
With && chains flowing smooth as a stream,
Backslashes gone—a formatter's dream!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'style(test): apply shfmt formatting to E2E scripts' clearly and specifically describes the main change: applying shfmt formatting fixes to E2E test scripts.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/e2e-shfmt-formatting

Comment @coderabbitai help to get the list of available commands and usage tips.

@wscurran wscurran added testing enhancement: testing Use this label to identify requests to improve NemoClaw test coverage. and removed testing labels Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement: testing Use this label to identify requests to improve NemoClaw test coverage.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants