Fix retrieve_all for containers with large capacity#580
Merged
PointKernel merged 8 commits intoNVIDIA:devfrom Aug 16, 2024
Merged
Fix retrieve_all for containers with large capacity#580PointKernel merged 8 commits intoNVIDIA:devfrom
PointKernel merged 8 commits intoNVIDIA:devfrom
Conversation
PointKernel
added
type: bug
PointKernel
changed the title
sleeepyjack
approved these changes
Aug 16, 2024
sleeepyjack
reviewed
Aug 16, 2024
jamxia155
pushed a commit
to rapidsai/gqe
that referenced
this pull request
Dec 11, 2025
…gqe!197) The following changes are addressed in the MR - Upgrading rapids-24.08 and cudf-24.08 - Cudf stopped exporting `cudf::detail::initialize_with_identity`, temporarily solved by copying the function definition - Upgrading to newer version of cucollection that temporarily fixes [cccl's retrieve_all bug](NVIDIA/cuCollections#580) - They updated the key equality comparison internally so that the slot content is always on the right-hand side and the query key is on the left-hand side ([here](NVIDIA/cuCollections#479)) - Improving groupby implementation for enabling TPC-H SF1k Q18 - Freeing memory that is no longer used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #576
This PR fixes the large input retrieve_all bug with a method similar to the streaming approach mentioned in NVIDIA/cccl#1422 (comment).
To be reverted once the CCCL fix is in place.