Fix pathfinder imports and handle access#814
Merged
leofang merged 2 commits intoNVIDIA:mainfrom Aug 7, 2025
Merged
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
/ok to test |
leofang
added
enhancement
leofang
approved these changes
Aug 7, 2025
Member
leofang
left a comment
leofang
left a comment
There was a problem hiding this comment.
LGTM, is there anything else needed?
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
kkraus14
added
the
to-be-backported
github-actions bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Remove pathfinder redirect, update usage * fix handle attribute (cherry picked from commit 15e99e9)
|
Successfully created backport PR for |
leofang
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Remove pathfinder redirect, update usage * fix handle attribute (cherry picked from commit 15e99e9) Co-authored-by: Keith Kraus <[email protected]>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #811
Updates the pathfinder imports and handle access in the CUDA bindings. Working on code-gen updates alongside these changes.
Changes Made:
cuda.bindings.path_finderwithcuda.pathfinderload_nvidia_dynamic_libfunction directly instead of importing the module.handleto._handlefor private attribute accessnvvm_linux.pyxandnvvm_windows.pyxnvjitlink_linux.pyxandnvjitlink_windows.pyxcufile_linux.pyxcynvrtc.pyx.inFiles Modified:
cuda_bindings/cuda/bindings/_bindings/cynvrtc.pyx.incuda_bindings/cuda/bindings/_internal/cufile_linux.pyxcuda_bindings/cuda/bindings/_internal/nvjitlink_linux.pyxcuda_bindings/cuda/bindings/_internal/nvjitlink_windows.pyxcuda_bindings/cuda/bindings/_internal/nvvm_linux.pyxcuda_bindings/cuda/bindings/_internal/nvvm_windows.pyxChecklist