Remove llvmlite from test dependencies in cuda_bindings/pyproject.toml#988
Merged
leofang merged 1 commit intoNVIDIA:mainfrom Sep 19, 2025
Merged
Remove llvmlite from test dependencies in cuda_bindings/pyproject.toml#988leofang merged 1 commit intoNVIDIA:mainfrom
llvmlite from test dependencies in cuda_bindings/pyproject.toml#988leofang merged 1 commit intoNVIDIA:mainfrom
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test |
Collaborator
Author
|
Logging a full error for easy future reference: |
This comment has been minimized.
This comment has been minimized.
leofang
approved these changes
Sep 19, 2025
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
|
Successfully created backport PR for |
leofang
pushed a commit
that referenced
this pull request
Sep 19, 2025
…oml (#988) (#993) (cherry picked from commit 95ffffe) Co-authored-by: Ralf W. Grosse-Kunstleve <[email protected]>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply removes
llvmlitefrom thetestdependencies, with leads to turning off the failing tests.Our existing
MINIMAL_NVVMIR_BITCODE_STATICdictionary is currently sufficient to exercise thenvvmbindings on all platforms.For easy future reference, the
llvmlite==0.45release caused these test failures: