support module.classname config specification for plugins#1108
Merged
jmartin-tech merged 1 commit intoNVIDIA:mainfrom Feb 24, 2025
Merged
Conversation
Original config support was intended to maintain this support in a deprecated format. Planned feature functionality suggests this should officially be maintained and is helpful to have aligned with how the cli accepts plugin values. Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
erickgalinkin
approved these changes
Feb 24, 2025
Collaborator
erickgalinkin
left a comment
There was a problem hiding this comment.
Makes sense to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original config support was intended to maintain this support in a deprecated format. Planned feature functionality suggests this should officially be maintained and is helpful to have aligned with how the cli accepts plugin values.
Verification
List the steps needed to make sure this thing works
hf_RigoChat_gpu.yamlgarak -m huggingface.Model -p test.Test --config hf_RigoChat_gpu.yamlSpecific Hardware:
cudacapable GPU for the example config howevermpscould be substituted on arm based macOS.