Skip to content

Bump datasets version#1137

Merged
jmartin-tech merged 3 commits intoNVIDIA:mainfrom
JanetVictorious:feature/bump-datasets-version
Apr 2, 2025
Merged

Bump datasets version#1137
jmartin-tech merged 3 commits intoNVIDIA:mainfrom
JanetVictorious:feature/bump-datasets-version

Conversation

@JanetVictorious
Copy link
Contributor

@JanetVictorious JanetVictorious commented Mar 24, 2025

Add support for datasets>2.17. This PR resolves issue #1136.

Change is to support version 3.0.0 and upwards.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅

@JanetVictorious
Copy link
Contributor Author

I have read the DCO Document and I hereby sign the DCO

@JanetVictorious
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request Mar 24, 2025
@JanetVictorious
Copy link
Contributor Author

Can this be merged or are there any changes that need to be made? Ping @leondz @jmartin-tech

@leondz
Copy link
Collaborator

leondz commented Mar 31, 2025

Will take a look (alle i virksomheden verden over havde ferie de sidste to dage i sidste uge :) )

@leondz
Copy link
Collaborator

leondz commented Mar 31, 2025

@JanetVictorious
Copy link
Contributor Author

Ok thanks for the update and the links, I will hold off then until it's verified we can safely bump the the version and then maybe skip 2.18.0 if it also entails problems (härligt med lite semester :) )

Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original restriction here was put in place due to a transitive dependency on fsspec[http] that still holds the same minimum version restriction in datasets though some mitigation code has been added that should ensure compatible function with old and newer versions of fsspec. While basic testing shows this works with datasets>=2.18.0 it may be more appropriate to bump this to datasets>=3.0.0 updating to a expect compatibility with the latest major version.

@jmartin-tech jmartin-tech merged commit 4e7f81b into NVIDIA:main Apr 2, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2025
@JanetVictorious JanetVictorious deleted the feature/bump-datasets-version branch April 3, 2025 04:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants