Conversation
|
DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅ |
|
I have read the DCO Document and I hereby sign the DCO |
|
recheck |
|
Can this be merged or are there any changes that need to be made? Ping @leondz @jmartin-tech |
|
Will take a look (alle i virksomheden verden over havde ferie de sidste to dage i sidste uge :) ) |
|
|
Ok thanks for the update and the links, I will hold off then until it's verified we can safely bump the the version and then maybe skip |
jmartin-tech
left a comment
There was a problem hiding this comment.
The original restriction here was put in place due to a transitive dependency on fsspec[http] that still holds the same minimum version restriction in datasets though some mitigation code has been added that should ensure compatible function with old and newer versions of fsspec. While basic testing shows this works with datasets>=2.18.0 it may be more appropriate to bump this to datasets>=3.0.0 updating to a expect compatibility with the latest major version.
Add support for
datasets>2.17. This PR resolves issue #1136.Change is to support version 3.0.0 and upwards.