Conversation
jmartin-tech
left a comment
There was a problem hiding this comment.
The tier list should be a constant enum in probes/base.Probe and each entry should be a value from that enum. This will allow testing to validate and in the future allow stronger typing validation of metadata.
|
What's your favourite implementation of constant enums in py?
|
|
:vibrating eyes: |
|
After this landed I notice this does not set |
|
Former is due to some multiply inheriting classes having poor inheritance order. Latentinjection refactor addresses some of these cases. |
Add
tiervalues toprobes, indicating the priority of each probe.Verification
python -m pytest tests/probes/test_probes.py::test_probe_metadata