Fix ambiguous series value error when running --report#1171
Merged
jmartin-tech merged 3 commits intoNVIDIA:mainfrom May 5, 2025
Merged
Fix ambiguous series value error when running --report#1171jmartin-tech merged 3 commits intoNVIDIA:mainfrom
jmartin-tech merged 3 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Marco Rosa <10925009+marcorosa@users.noreply.github.com>
Contributor
|
DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅ |
Contributor
Author
|
I have read the DCO Document and I hereby sign the DCO |
Contributor
Author
|
recheck |
Collaborator
|
Thanks for the PR @marcorosa! Is there any way you can share the |
Contributor
Author
|
Hi @erickgalinkin, it was just the result of running dan over mistral. I ran other tests and I have overwritten the .jsonl, but I still have the DataFrame in a python shell in case it can help you (you see DanInTheWildMini because I am using garak v0.10.x from pypi, but it's the same if you run the alpha v0.11 building the main branch) |
erickgalinkin
pushed a commit
to erickgalinkin/garak
that referenced
this pull request
Apr 24, 2025
leondz
reviewed
Apr 25, 2025
leondz
previously requested changes
Apr 25, 2025
Collaborator
leondz
left a comment
There was a problem hiding this comment.
Nice catch, thank you! One correction re: scale
Co-authored-by: Leon Derczynski <leonderczynski@gmail.com> Signed-off-by: Marco Rosa <10925009+marcorosa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actual issue
This commit introduced a bug: while it avoids the ZeroDivisionError exception that would be raised if total is =0 for one of the probes, it introduces another bug with the usage of pandas.
How to reproduce
After running a test with some probe, run the report evaluations on the output file.
Python script:
There is also a CLI with
-ron the.jsonlresult file.The fix
Use
numpy.wherefor that conditional division.Verification
It seems there is no coverage for the
--report/-rfeature, so I just ran the python script above