update: rename Translator -> LangProvider and associated elements#1183
Merged
jmartin-tech merged 3 commits intoNVIDIA:mainfrom Apr 28, 2025
Merged
update: rename Translator -> LangProvider and associated elements#1183jmartin-tech merged 3 commits intoNVIDIA:mainfrom
Translator -> LangProvider and associated elements#1183jmartin-tech merged 3 commits intoNVIDIA:mainfrom
Conversation
jmartin-tech
approved these changes
Apr 28, 2025
Collaborator
jmartin-tech
left a comment
jmartin-tech
left a comment
There was a problem hiding this comment.
Looks good, thank you for addressing the service load() naming.
Final testing in progress should land shortly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to work at the right level of abstraction, which should be a little higher than translator when the name covers things that don't translate
This starts to set us up better for abstractions around prompt assembly
Verification