update LocalDataPath and testing for python 3.13 support#1188
Merged
jmartin-tech merged 3 commits intoNVIDIA:mainfrom Jun 27, 2025
Merged
update LocalDataPath and testing for python 3.13 support#1188jmartin-tech merged 3 commits intoNVIDIA:mainfrom
jmartin-tech merged 3 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
While we await a release or other resolution based on google/sentencepiece#1084 limit windows testing to working versions Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
jmartin-tech
force-pushed
the
feature/python3-13-support
branch
from
2fd7334 to
adc24fa
Compare
erickgalinkin
approved these changes
Jun 26, 2025
Collaborator
erickgalinkin
left a comment
erickgalinkin
left a comment
There was a problem hiding this comment.
LGTM with the asterisk around sentencepiece support for 3.13.
leondz
approved these changes
Jun 27, 2025
| strategy: | ||
| matrix: | ||
| python-version: ["3.10","3.12"] | ||
| python-version: ["3.10","3.12","3.13"] |
Collaborator
There was a problem hiding this comment.
intent with skipping 3.11 was to test lower & highest supported version. should we continue that pattern?
| return LocalDataPath(projected) | ||
|
|
||
| if projected in self.ORDERED_SEARCH_PATHS: | ||
| return LocalDataPath(projected) |
Collaborator
|
considering creating a pypi pkg |
jmartin-tech
commented
Jun 27, 2025
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
leondz
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates required for python 3.13 support.
Impacts from refactor of
pathliband addition of the newPurePathclass incpythonrequired implementation of a conditional method override forwith_segmentson 3.13+. This also required allowingORDERED_SEARCH_PATHSlocations to be considered validLocalDataPathobjects when the path does not already exist on the filesystem.Verification
List the steps needed to make sure this thing works