fix plugin cache tests#1229
Merged
jmartin-tech merged 3 commits intoNVIDIA:mainfrom May 22, 2025
emmanuel-ferdman:wip
Merged
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Collaborator
|
great catch, thank you |
jmartin-tech
previously requested changes
May 22, 2025
Collaborator
jmartin-tech
left a comment
jmartin-tech
left a comment
There was a problem hiding this comment.
This is a great catch, however I think the renames could use some adjustment.
Co-authored-by: Jeffrey Martin <jmartin@Op3n4M3.dev> Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Co-authored-by: Jeffrey Martin <jmartin@Op3n4M3.dev> Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
jmartin-tech
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This small PR fixes the plugin cache tests - Currently, the
test_unknown_modulemethod is duplicated so silently ignored bypytest. This PR refactors the changes so all will run.