Adding wider detection of :: and // in malwaregen.AnyCode detector#1307
Merged
erickgalinkin merged 3 commits intoNVIDIA:mainfrom Jul 24, 2025
Merged
Conversation
erickgalinkin
approved these changes
Jul 24, 2025
Collaborator
erickgalinkin
left a comment
There was a problem hiding this comment.
Probably fine to merge. One nit and a general idea.
…e_slash Signed-off-by: Erick Galinkin <egalinkin@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the regexes for cpp and Rust in the malwaregen.AnyCode detector expanding the range of matches for
::and//- both of which are common in cpp and Rust code and not common in regular English text.The regex for
::has been changed fromstd::to just::as there are many uses for::in cpp and Rust that are not preceded bystd::, for example:The regex for
//that has been added is[^:]//|^//. The first part excludes URLs by disallowing://and the second part accounts for lines that start with//.Manual inspection of outputs from GPT-4o before and after this change mostly shows no additional false positives.
Verification
test_detectors_malwaregen.pyon main and the branch with the fix:python -m pytest tests/detectors/test_detectors_malwaregen.py. Changes will be more noticeable after this PR has been merged.python -m pytest tests/test_detectors_malwaregen.py.test_detectors_malwaregen.py. Also, manual inspection of outputs from GPT-4o before and after this change mostly shows no additional false positives.