Skip to content

download models used in translation tests early#1308

Merged
erickgalinkin merged 1 commit intoNVIDIA:mainfrom
jmartin-tech:fix/explicit-macos-huggingface-downloads
Jul 25, 2025
Merged

download models used in translation tests early#1308
erickgalinkin merged 1 commit intoNVIDIA:mainfrom
jmartin-tech:fix/explicit-macos-huggingface-downloads

Conversation

@jmartin-tech
Copy link
Collaborator

MacOS runners often exhibit errors when downloading some huggingface models due to kernel network buffering issues similar to this reference.

To reduce these errors, suppress the huggingface Xet protocol and prep the cache with early downloads.

In theory this could just set the environment variable before executing any tests, this change intentionally limits the scope of environment changes to a separate process before tests execute.

Verification

  • MacOS testing automation passes

Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
@jmartin-tech jmartin-tech added tests Testing-related housekeeping Repository and project maintenance labels Jul 25, 2025
Copy link
Collaborator

@erickgalinkin erickgalinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVAL

@erickgalinkin erickgalinkin merged commit ed53c00 into NVIDIA:main Jul 25, 2025
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2025
@jmartin-tech jmartin-tech deleted the fix/explicit-macos-huggingface-downloads branch July 25, 2025 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

housekeeping Repository and project maintenance tests Testing-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants