fix: aggregate probes details in digest#1459
Merged
jmartin-tech merged 2 commits intoNVIDIA:mainfrom Nov 6, 2025
Merged
Conversation
Signed-off-by: Paul A. Parkanzky <pparkanzky@nvidia.com>
Contributor
|
DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅ |
Collaborator
Author
|
recheck |
Collaborator
Author
|
I have read the DCO Document and I hereby sign the DCO |
Collaborator
Author
|
recheck |
jmartin-tech
previously requested changes
Nov 5, 2025
Signed-off-by: Paul A. Parkanzky <pparkanzky@nvidia.com>
jmartin-tech
reviewed
Nov 5, 2025
Collaborator
jmartin-tech
left a comment
There was a problem hiding this comment.
As this revision now builds the digest instead of making an attempt to merge all the various entires that might exist it results in calculations for z_scores and comments that based on current the installed version's calibration data. I am good with that change as aggregation should be performed using the same version that generated the individual reports, @leondz can you weigh in on if this is an acceptable change.
Changes accounted for, further review in progress.
jmartin-tech
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When aggregating jsonl reports from multiple garak invocations using
garak.analyze.aggregate_reports, probe specs in thestart_runanddigestentries were not correctly aggregated. This change aggregates the probe specs from each jsonl output.Tests had included the incorrect
digestaggregation and ignored incorrectstart_runaggregation. This updates the test and tests both places.Verification
List the steps needed to make sure this thing works
python -m pytest tests/python -m garak.analyze.aggregate_reports -o ./aggregated.jsonl <list of report jsonls>start_runentryplugins.probe_specstring value is a comma separated list of aggregated probespecs which includes all probespecs from all aggregated report jsonls.digestentryprobespecstring value is the same comma separated list of aggregated probespecspython -m garak.analyze.report_digest -w -r ./aggregated.jsonl > ./report.htmlprobe spec:value includes the aggregated probespecs from individual runs.