fix: metadata and vuln_id handling in AVID report export#1495
fix: metadata and vuln_id handling in AVID report export#1495jmartin-tech merged 2 commits intoNVIDIA:mainfrom
Conversation
|
Thanks for this! Do you have a pointer to reproducing the fixed errors? They sound like they'd make decent tests |
leondz
left a comment
There was a problem hiding this comment.
The code looks good! Would appreciate info on test cases
erickgalinkin
left a comment
There was a problem hiding this comment.
+1 to Leon's comments. Would love to see the failing test cases but otherwise lgtm.
|
Hi @leondz & @erickgalinkin, thank you for looking into this. For the below sample run - Before any fixes:After the 1st update (entry type check from
|
|
Thanks!
Is it possible to create a new file in |
|
Ofc, thanks for the clarification. Will create a |
| ) | ||
| report.metrics = [ | ||
| ac.Metric( | ||
| name="", |
There was a problem hiding this comment.
Curious why name is an empty string.
jmartin-tech
left a comment
There was a problem hiding this comment.
Changes here have been validated for resolution of the reported failure. This will land shortly.
The question about naming the reported metric is still open to the original feature author.
Requested testing has been supplied.
Fix AVID report export errors related to metadata keys and the default vuln_id. details in this comment.
Changes:
configtostart_run setup.Fixes:
TypeError: 'NoneType' object is not subscriptablewhen metadata is accessedKeyError: 'target_type'when accessing metadataVerification
List the steps needed to make sure this thing works