update LangChain generator for 1.x library support#1551
Merged
jmartin-tech merged 3 commits intoNVIDIA:mainfrom Jan 23, 2026
Merged
update LangChain generator for 1.x library support#1551jmartin-tech merged 3 commits intoNVIDIA:mainfrom
jmartin-tech merged 3 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
leondz
reviewed
Jan 15, 2026
Collaborator
leondz
left a comment
leondz
left a comment
There was a problem hiding this comment.
one q around config param var use
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
Collaborator
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update langchain support for 1.x library. This maintains the limited support in this generator as being for direct model
invoke()calls and expands the generator to supportConversationbased prompts using the OpenAI format.Enhancement also supports injection of a specific
model_provideras defined in the 1.x langchain chat interface and forwarding ofconfigurable_fieldspassed as asetvia configuration.Verification
List the steps needed to make sure this thing works
garak -t langchain -n <model_name>