fix: 100% pass rate should not give 'elevated risk' for relative scores#1579
Merged
jmartin-tech merged 3 commits intoNVIDIA:mainfrom Jan 28, 2026
Merged
Conversation
jmartin-tech
approved these changes
Jan 28, 2026
Collaborator
jmartin-tech
left a comment
There was a problem hiding this comment.
Look good, follow on ideas also make sense to consider in future iteration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean sheet score could yield inappropriate
relative_comment:this PR
relative_commentto max instead of justrelative_defcon&absolute_defconmaybe later we could
calibration.defcon_and_comment()to justcalibration.defcon(), or evencalibration.defcon_and_comment()andreport_digest.map_absolute_score()and have a single score-to-defcon map function referencing a boundary class fromanalyze.__init__