This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Increase contrast of search input text in docs.#1644
Merged
alliepiper merged 1 commit intoNVIDIA:mainfrom Mar 24, 2022
Merged
Conversation
Collaborator
|
Thanks! I'll go ahead and merge this to stay sync'd with libcu++. Pinging @brycelelbach for awareness.
AFAIK those are the only two projects that use this scheme. |
alliepiper
approved these changes
Mar 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See related fix to libcudacxx: NVIDIA/libcudacxx#258
This PR increases the contrast of the documentation's search bar text so that the input text is legible.
If reviewers are aware of other instances of this issue beyond libcudacxx/thrust, let me know and I can make corresponding updates to other repositories.
I verified that this fix works for Firefox, Chrome, and Edge browsers. All three browsers show light text on a dark background in the placeholder text and when input is entered.
Before, without input (Firefox):

After, without input (Firefox):

After, with input (Chrome):
