This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Reference CUDA back end functions only when CUDA back end is enabled#1722
Merged
alliepiper merged 1 commit intomainfrom Jun 17, 2022
Merged
Reference CUDA back end functions only when CUDA back end is enabled#1722alliepiper merged 1 commit intomainfrom
alliepiper merged 1 commit intomainfrom
Conversation
Add a #if block to temporary_allocator<T,S>::allocate in thrust/detail/allocator/temporary_allocator.inl so that the CUDA back end function thrust::system::cuda::detail::terminate_with_message is referenced only when the CUDA back end is enabled. Putting the reference within the device-specific branch of an NV_IF_TARGET isn't good enough; there are some situations, e.g. 'nvc++ -cuda -stdpar=multicore', where that doesn't work and an explicit check for the CUDA back end is necessary.
dkolsen-pgi
added
compiler: nvc++
alliepiper
added
type: bug: functional
Collaborator
|
LGTM -- this can go in once testing finishes. run tests |
alliepiper
approved these changes
Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
#ifblock totemporary_allocator<T,S>::allocateinthrust/detail/allocator/temporary_allocator.inlso that the CUDA back endfunction
thrust::system::cuda::detail::terminate_with_messageis referencedonly when the CUDA back end is enabled. Putting the reference within the
device-specific branch of an
NV_IF_TARGETisn't good enough; there are somesituations, e.g.
nvc++ -cuda -stdpar=multicore, where that doesn't workand an explicit check for the CUDA back end is necessary.