This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Correct install(PATTERN) to match end of filenames#1825
Merged
gevtushenko merged 1 commit intoNVIDIA:mainfrom Nov 9, 2022
Merged
Correct install(PATTERN) to match end of filenames#1825gevtushenko merged 1 commit intoNVIDIA:mainfrom
gevtushenko merged 1 commit intoNVIDIA:mainfrom
Conversation
robertmaynard
added
type: bug: functional
gevtushenko
suggested changes
Nov 9, 2022
Collaborator
gevtushenko
left a comment
gevtushenko
left a comment
There was a problem hiding this comment.
The same comment as on the CUB side of this PR. *.cmake.in files are used below to generate *.cmake files on the installation side. I don't see why we need *.cmake.in files in the installation. Unless I'm missing something, let's remove this.
gevtushenko
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PATTERNmatches at the end of filenames not the front, so we need to specify*.cmake.into exclude the template files.