Skip to content

feat(webapp): redesign auth pages#5518

Open
kaposke wants to merge 6 commits intomasterfrom
gui/NAN-4758/feat-redesign-auth
Open

feat(webapp): redesign auth pages#5518
kaposke wants to merge 6 commits intomasterfrom
gui/NAN-4758/feat-redesign-auth

Conversation

@kaposke
Copy link
Contributor

@kaposke kaposke commented Feb 25, 2026

Redesigns and refactors every auth screen in the auth flow. Moved every request to a tanstack-query hooks, so there's a lot of volume.

Pictures of screens that are harder to get to:

When you click an invite link while being logged out:
image

When trying to sign up in invite link but the account already exists:
image

When opening the invite link while logged in in the correct account:
image

When opening the invite link while logged in in the incorrect account:
image

When opening an invalid invite link
image

Most other screens are easy to get to, appreciate you testing them!


It also updates all auth-related pages to the v2 design system using the new DefaultLayout and rebuilds forms with react-hook-form and zod validation, while introducing a new useAuth hook module that migrates legacy apiFetch/SWR-based auth, invite, and onboarding requests to typed query/mutation hooks along with supporting utility and type updates.

Possible Issues

inviteResponse can be null until fetched; verify there is no blank screen in slow networks where a skeleton or loading state is expected
• The DefaultLayout fixed width (w-[485px]) may cause layout issues on very small screens if min-w is too large
• The useInvite hook now returns a union status response; ensure all callers correctly handle the 400 response path and do not assume 200 data


This summary was automatically generated by @propel-code-bot

@linear
Copy link

linear bot commented Feb 25, 2026

@kaposke kaposke changed the title Gui/nan 4758/feat redesign auth feat(webapp): redesign auth pages Feb 25, 2026
@kaposke kaposke requested a review from a team February 25, 2026 16:29
@kaposke kaposke marked this pull request as ready for review February 25, 2026 16:29
propel-code-bot[bot]

This comment was marked as outdated.

@marcindobry
Copy link
Contributor

When fields are invalid, the button is just greyed out but it's unclear what's invalid. Some tooltip or highlight would be helpful
Screenshot 2026-02-26 at 19 23 50
Screenshot 2026-02-26 at 19 24 14

</div>
{children}
<div className="w-full h-full flex justify-center items-center py-22">
{/* Card */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a random comment, should it be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just highlighting the part that it's the card in the middle.

@kaposke kaposke force-pushed the gui/NAN-4758/feat-redesign-auth branch from 75b7c3d to 5a54d9d Compare March 2, 2026 21:49
@kaposke
Copy link
Contributor Author

kaposke commented Mar 2, 2026

When fields are invalid, the button is just greyed out but it's unclear what's invalid. Some tooltip or highlight would be helpful

Whoops. I made the button disabling thing as one of the last things and didn't notice there was no way to trigger validation that way. Added mode: 'onTouched' to all the forms. A field is now validated for the first time on blur, and then again on any new updates.

@kaposke kaposke requested a review from marcindobry March 2, 2026 21:51
Copy link
Contributor

@propel-code-bot propel-code-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a logic regression where the password requirements panel stays open after blur and loses blur tracking.

Status: Changes Suggested | Risk: Medium

Issues Identified & Suggestions
  • Restore onBlur to close requirements panel and trigger blur tracking: Password.tsx
Review Details

📁 18 files reviewed | 💬 1 comments

Instruction Files
├── .claude/
│   ├── agents/
│   │   └── nango-docs-migrator.md
│   └── skills/
│       ├── agent-builder-skill/
│       │   ├── EXAMPLES.md
│       │   └── SKILL.md
│       ├── creating-integration-docs/
│       │   └── SKILL.md
│       └── creating-skills-skill/
│           └── SKILL.md
├── AGENTS.md
└── GEMINI.md

👍 / 👎 individual comments to help improve reviews for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants