feat(server): run credentials verification on the connection import endpoint#5538
Open
hassan254-prog wants to merge 3 commits intomasterfrom
Open
Conversation
5892d93 to
7afa326
Compare
7afa326 to
db20d28
Compare
db20d28 to
f3d3bc3
Compare
…event-on-the-import-connection
Contributor
There was a problem hiding this comment.
Review found no issues with the implemented credential verification and validation flow.
Status: No Issues Found | Risk: Low
Review Details
📁 2 files reviewed | 💬 0 comments
Instruction Files
├── .claude/
│ ├── agents/
│ │ └── nango-docs-migrator.md
│ └── skills/
│ ├── agent-builder-skill/
│ │ ├── EXAMPLES.md
│ │ └── SKILL.md
│ ├── creating-integration-docs/
│ │ └── SKILL.md
│ └── creating-skills-skill/
│ └── SKILL.md
├── AGENTS.md
└── GEMINI.md
TBonnin
approved these changes
Mar 2, 2026
| integrationId: integration.id!, | ||
| integrationName: integration.unique_key, | ||
| providerName | ||
| }); |
Collaborator
There was a problem hiding this comment.
you can pass all this integration info to create. no need to use enrichOperation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the problem and your solution
It also adds structured log context lifecycle handling around success and failure paths and expands API error typing to expose new error codes when credential tests or validation fail.
Possible Issues
• Credential test failures are treated as
400; confirm alignment with existing API semantics for invalid credentials.• Custom validation failure deletes only on
creation; ensure expected behavior foroverrideoperations.This summary was automatically generated by @propel-code-bot