Skip to content

feat(server): run credentials verification on the connection import endpoint#5538

Open
hassan254-prog wants to merge 3 commits intomasterfrom
wari/nan-4756-add-connection-verification-event-on-the-import-connection
Open

feat(server): run credentials verification on the connection import endpoint#5538
hassan254-prog wants to merge 3 commits intomasterfrom
wari/nan-4756-add-connection-verification-event-on-the-import-connection

Conversation

@hassan254-prog
Copy link
Contributor

@hassan254-prog hassan254-prog commented Feb 27, 2026

Describe the problem and your solution

  • run credentials verification and connection validation on the connection import endpoint

It also adds structured log context lifecycle handling around success and failure paths and expands API error typing to expose new error codes when credential tests or validation fail.

Possible Issues

• Credential test failures are treated as 400; confirm alignment with existing API semantics for invalid credentials.
• Custom validation failure deletes only on creation; ensure expected behavior for override operations.


This summary was automatically generated by @propel-code-bot

@hassan254-prog hassan254-prog self-assigned this Feb 27, 2026
@linear
Copy link

linear bot commented Feb 27, 2026

propel-code-bot[bot]

This comment was marked as outdated.

@hassan254-prog hassan254-prog marked this pull request as draft February 27, 2026 12:16
@hassan254-prog hassan254-prog marked this pull request as ready for review February 27, 2026 13:15
propel-code-bot[bot]

This comment was marked as outdated.

@hassan254-prog hassan254-prog force-pushed the wari/nan-4756-add-connection-verification-event-on-the-import-connection branch from 5892d93 to 7afa326 Compare February 27, 2026 15:31
propel-code-bot[bot]

This comment was marked as outdated.

@hassan254-prog hassan254-prog requested a review from a team February 27, 2026 19:53
@hassan254-prog hassan254-prog force-pushed the wari/nan-4756-add-connection-verification-event-on-the-import-connection branch from 7afa326 to db20d28 Compare March 2, 2026 11:52
@hassan254-prog hassan254-prog force-pushed the wari/nan-4756-add-connection-verification-event-on-the-import-connection branch from db20d28 to f3d3bc3 Compare March 2, 2026 12:32
propel-code-bot[bot]

This comment was marked as outdated.

Copy link
Contributor

@propel-code-bot propel-code-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review found no issues with the implemented credential verification and validation flow.

Status: No Issues Found | Risk: Low

Review Details

📁 2 files reviewed | 💬 0 comments

Instruction Files
├── .claude/
│   ├── agents/
│   │   └── nango-docs-migrator.md
│   └── skills/
│       ├── agent-builder-skill/
│       │   ├── EXAMPLES.md
│       │   └── SKILL.md
│       ├── creating-integration-docs/
│       │   └── SKILL.md
│       └── creating-skills-skill/
│           └── SKILL.md
├── AGENTS.md
└── GEMINI.md

integrationId: integration.id!,
integrationName: integration.unique_key,
providerName
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can pass all this integration info to create. no need to use enrichOperation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants